test(orchestrator): Align post-merge CTM fixtures#4193
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved All changes are confined to test files and test fixtures, with no production code modified. The updates align expected values after a merge, with zero runtime behavior impact. You can customize Macroscope's approvability policy. Learn more. |
462e3b4 to
46f08ee
Compare
46f08ee to
3ec80f3
Compare
Summary
userdata-v2state directory.
query.openframes for the current read-only toolavailability policy.
updates.
Problem and Fix
userdatadirectory even though explicit server paths resolve underuserdata-v2.claude_codetool preset after CTM began passing explicit read-only tool lists.query.openframes to expectRead,Glob, andGrep, includingallowedToolswhere the runtime policy supplies it.Validation
fixtures: 17 tests pass, 1 skipped
vp check: pass with existing warnings onlyvp run typecheck: passNote
Align CTM test fixtures to use explicit tool lists and
userdata-v2state directoryclaude_transcript.ndjsonfixtures intool_call_read_only_on_requestandtool_call_restricted_granularto expect an explicit["Read", "Glob", "Grep"]tool list instead of a{type: "preset", preset: "claude_code"}object;tool_call_read_only_on_requestalso addsallowedToolsto the expected payload.stateDiranddbPathunderuserdata-v2instead ofuserdata.Macroscope summarized 3ec80f3.
Note
Low Risk
Only test assertions and recorded replay fixtures change; no production code paths are modified.
Overview
Brings post-merge CI fixtures in line with orchestrator v2 path layout and the current Claude agent tool policy—test and replay expectations only, no runtime behavior changes.
CLI config tests now assert
stateDiranddbPathunderuserdata-v2instead ofuserdata, matching explicit-serverderiveServerPathsbehavior after the v2 state directory switch.Two orchestration-v2 Claude replay transcripts update the expected
query.openpayload: the unrestrictedclaude_codetool preset is replaced with an explicit["Read", "Glob", "Grep"]list (andallowedToolson the read-only-on-request scenario) so CTM replay matches how CTM now opens sessions with read-only tools.Reviewed by Cursor Bugbot for commit 3ec80f3. Bugbot is set up for automated code reviews on this repo. Configure here.